jonkeane commented on PR #38236: URL: https://github.com/apache/arrow/pull/38236#issuecomment-1761679457
I've tried this out locally on both an x86 and an M2 from this branch. And it worked well 🎉 One thing I noticed in the logs is that there appears to be an errant 0 coming from the second half of this line https://github.com/apache/arrow/blob/e9aac8a4ce4b8833667efe52957fb0881a488c4b/r/configure#L267 Looks like it was discussed a bit https://github.com/apache/arrow/pull/37684#discussion_r1343484287 but not that `expr` always prints to stdout. I propose we change that line to `if [ "$UNAME" = "Darwin" ] && [ $(sw_vers -productVersion) = '10.13' ]; then` It's a little bit out of scope for this PR (we should have caught it in #37684) but would you mind making it here so that we clean this up before we release? See below: ``` jkeane@het r % if expr $(sw_vers -productVersion) : '10\.13'; then echo "inside" fi 0 $ if [ $(sw_vers -productVersion) = '10.13' ]; then echo "inside" fi # my system is 12.7, so this will be true $ if expr $(sw_vers -productVersion) : '12\.7'; then echo "inside" fi 4 inside $ if [ $(sw_vers -productVersion) = '12.7' ]; then echo "inside" fi inside ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
