lidavidm commented on code in PR #38248:
URL: https://github.com/apache/arrow/pull/38248#discussion_r1357198407
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java:
##########
@@ -237,6 +237,27 @@ public VectorSchemaRoot read() throws IOException {
}
}
+ /**
+ * Skips a number of record batches in the file.
+ *
+ * @param numBatches the number of batches to skip
+ * @return the actual number of skipped batches.
+ */
+ public int skip(int numBatches) throws IOException {
Review Comment:
It might be useful to note that this is invoked via JPype in the integration
tests, since IDE users will be tempted to delete it as something unused (in
Java)
##########
java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryProvider.java:
##########
@@ -49,6 +51,21 @@ public MapDictionaryProvider(Dictionary... dictionaries) {
}
}
+ /**
+ * Initialize the map structure from another provider, but with empty
vectors.
+ *
+ * @param other the {@link DictionaryProvider} to copy the ids and fields
from
+ * @param allocator allocator to create the empty vectors
+ */
+ public void copyStructureFrom(DictionaryProvider other, BufferAllocator
allocator) {
Review Comment:
Ditto here, we should note that it's only used from JNI. (Can JPype invoke a
protected or private method? I guess not, but it would be good to signal that
this isn't meant to be a public function really.) We could mark it
[`@VisibleForTesting`](https://github.com/apache/arrow/blob/01b42d51ba97cb12c17e5b001c65b38741ea83ba/java/memory/memory-core/src/main/java/org/apache/arrow/util/VisibleForTesting.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
