pitrou commented on code in PR #38248:
URL: https://github.com/apache/arrow/pull/38248#discussion_r1365333915
##########
dev/archery/archery/integration/tester_go.py:
##########
@@ -225,14 +222,10 @@ def supports_releasing_memory(self):
return True
def record_allocation_state(self):
- self._run_gc()
return self.dll.ArrowGo_BytesAllocated()
- def compare_allocation_state(self, recorded, gc_until):
- def pred():
- return self.record_allocation_state() == recorded
-
- return gc_until(pred)
+ # Note: no need to call the Go GC anywhere thanks to Arrow Go's
+ # explicit refcounting.
Review Comment:
@zeroshade Your changes did the trick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
