llama90 commented on PR #38147: URL: https://github.com/apache/arrow/pull/38147#issuecomment-1760187899
@pitrou I have enhanced the hash join tests as you mentioned, by modifying the existing unit test code. I confirmed that the random generator does not create data types corresponding to `uint64_t`, which is considered 'Large'. Accordingly, I have updated it to generate LargeString type data. This appears to adequately generate data for offset calculations. An error occurs when testing based on the previously written `Slice` function code. I'm still contemplating for the `Slice` function and need more time to consider the best approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
