llama90 commented on code in PR #38147:
URL: https://github.com/apache/arrow/pull/38147#discussion_r1358499371
##########
cpp/src/arrow/compute/light_array.h:
##########
@@ -183,6 +183,36 @@ class ARROW_EXPORT KeyColumnArray {
// Starting bit offset within the first byte (between 0 and 7)
// to be used when accessing buffers that store bit vectors.
int bit_offset_[kMaxBuffers - 1];
+
+ bool is_dictionary_type() const {
+ return metadata_.is_fixed_length && metadata_.fixed_length != 0 &&
+ !metadata_.is_null_type;
Review Comment:
You are correct. I overlooked that.
##########
cpp/src/arrow/compute/light_array.h:
##########
@@ -183,6 +183,36 @@ class ARROW_EXPORT KeyColumnArray {
// Starting bit offset within the first byte (between 0 and 7)
// to be used when accessing buffers that store bit vectors.
int bit_offset_[kMaxBuffers - 1];
+
+ bool is_dictionary_type() const {
+ return metadata_.is_fixed_length && metadata_.fixed_length != 0 &&
+ !metadata_.is_null_type;
Review Comment:
You are correct. I overlooked that.
##########
cpp/src/arrow/compute/light_array.h:
##########
@@ -183,6 +183,36 @@ class ARROW_EXPORT KeyColumnArray {
// Starting bit offset within the first byte (between 0 and 7)
// to be used when accessing buffers that store bit vectors.
int bit_offset_[kMaxBuffers - 1];
+
+ bool is_dictionary_type() const {
+ return metadata_.is_fixed_length && metadata_.fixed_length != 0 &&
+ !metadata_.is_null_type;
+ }
+
+ bool is_bool_type() const {
+ return metadata_.is_fixed_length && metadata_.fixed_length == 0 &&
+ !metadata_.is_null_type;
+ }
+
+ bool is_other_fixed_width_types() const {
+ return metadata_.is_fixed_length && metadata_.fixed_length != 0 &&
+ !metadata_.is_null_type;
+ }
Review Comment:
You are correct. I overlooked that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
