tustvold commented on code in PR #4931:
URL: https://github.com/apache/arrow-rs/pull/4931#discussion_r1358472515
##########
object_store/src/local.rs:
##########
@@ -1604,15 +1575,15 @@ mod unix_test {
let path = root.path().join(filename);
unistd::mkfifo(&path, stat::Mode::S_IRWXU).unwrap();
- let location = Path::from(filename);
- integration.head(&location).await.unwrap();
-
// Need to open read and write side in parallel
let spawned = tokio::task::spawn_blocking(|| {
- OpenOptions::new().write(true).open(path).unwrap();
+ OpenOptions::new().write(true).open(path).unwrap()
});
+ let location = Path::from(filename);
+ integration.head(&location).await.unwrap();
Review Comment:
This has to be moved after the spawn_blocking as it now will open the file,
I don't see this being an issue as the behaviour of a head request on a file
that gets mutated behind the scenes are not exactly very well defined anyway
:sweat_smile:
##########
object_store/src/local.rs:
##########
@@ -1604,15 +1575,15 @@ mod unix_test {
let path = root.path().join(filename);
unistd::mkfifo(&path, stat::Mode::S_IRWXU).unwrap();
- let location = Path::from(filename);
- integration.head(&location).await.unwrap();
-
// Need to open read and write side in parallel
let spawned = tokio::task::spawn_blocking(|| {
- OpenOptions::new().write(true).open(path).unwrap();
+ OpenOptions::new().write(true).open(path).unwrap()
});
+ let location = Path::from(filename);
+ integration.head(&location).await.unwrap();
Review Comment:
This has to be moved after the spawn_blocking as it now will open the file,
which will block until the writer opens it, I don't see this being an issue as
the behaviour of a head request on a file that gets mutated behind the scenes
are not exactly very well defined anyway :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
