tustvold commented on code in PR #4931:
URL: https://github.com/apache/arrow-rs/pull/4931#discussion_r1358473737
##########
object_store/src/local.rs:
##########
@@ -1604,15 +1575,15 @@ mod unix_test {
let path = root.path().join(filename);
unistd::mkfifo(&path, stat::Mode::S_IRWXU).unwrap();
- let location = Path::from(filename);
- integration.head(&location).await.unwrap();
-
// Need to open read and write side in parallel
let spawned = tokio::task::spawn_blocking(|| {
- OpenOptions::new().write(true).open(path).unwrap();
Review Comment:
This semicolon fixes a subtle bug, where the writer is immediately dropped
which then causes subsequent opens to block. I'm actually somewhat surprised it
has worked semi-reliably so far
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
