amoeba commented on code in PR #38267: URL: https://github.com/apache/arrow/pull/38267#discussion_r1359771593
########## cpp/src/arrow/filesystem/s3fs.h: ########## @@ -378,5 +387,13 @@ Status EnsureS3Finalized(); ARROW_EXPORT Result<std::string> ResolveS3BucketRegion(const std::string& bucket); +/// \brief Try to extract the S3LogLevel from environment variable +/// +/// Tries to get a valid log level name from the environment variable +/// ARROW_S3_LOG_LEVEL and returns a matching value of S3LogLevel. If it fails +/// returns S3LogLevel::Fatal. +ARROW_EXPORT +S3LogLevel GetS3LogLevelFromEnvOrDefault(); Review Comment: Resolved this by renaming GetS3LogLevelFromEnvOrDefault to S3GlobalOptions::Defaults, as suggested in another comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
