amoeba commented on code in PR #38267:
URL: https://github.com/apache/arrow/pull/38267#discussion_r1361174468
##########
cpp/src/arrow/filesystem/s3fs.h:
##########
@@ -332,9 +332,24 @@ struct ARROW_EXPORT S3GlobalOptions {
///
/// For more details see Aws::Crt::Io::EventLoopGroup
int num_event_loop_threads = 1;
+
+ /// \brief Initialize with default options
+ ///
+ /// For log_level, this method first tries to extract a suitable value from
the
+ /// environment variable ARROW_S3_LOG_LEVEL.
+ static S3GlobalOptions Defaults();
};
-/// \brief Initialize the S3 APIs.
+/// \brief Initialize the S3 APIs with default options.
+///
+/// It is required to call this function at least once before using
S3FileSystem.
+///
+/// Once this function is called you MUST call FinalizeS3 before the end of the
+/// application in order to avoid a segmentation fault at shutdown.
+ARROW_EXPORT
+Status InitializeS3();
Review Comment:
No use case, no, just a personal preference thing. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
