js8544 commented on code in PR #37100:
URL: https://github.com/apache/arrow/pull/37100#discussion_r1359847075
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -516,7 +537,10 @@ void AddMinOrMaxAggKernel(ScalarAggregateFunction* func,
// Note SIMD level is always NONE, but the convenience kernel will
// dispatch to an appropriate implementation
- AddAggKernel(std::move(sig), std::move(init), std::move(finalize), func);
+ AddAggKernel(sig, init, finalize, func);
+
+ sig = KernelSignature::Make({InputType(Type::DICTIONARY)},
DictionaryValueType);
Review Comment:
Ah you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
