js8544 commented on code in PR #37100:
URL: https://github.com/apache/arrow/pull/37100#discussion_r1361474864
##########
cpp/src/arrow/compute/kernels/aggregate_test.cc:
##########
@@ -2175,6 +2175,468 @@ TEST(TestFixedSizeBinaryMinMaxKernel, Basics) {
EXPECT_THAT(MinMax(ScalarFromJSON(ty, R"("aa")"), options),
ResultWith(null));
}
+TEST(TestDictionaryMinMaxKernel, DecimalsValue) {
Review Comment:
IMO we have too many test cases, which will slow down compilation and CI.
Could you reduce them to 2~3 test cases for each data type? We don't need to
cover all test cases of their primitive kernels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
