AlenkaF commented on code in PR #38241: URL: https://github.com/apache/arrow/pull/38241#discussion_r1360295021
########## docs/source/conf.py: ########## @@ -288,6 +288,14 @@ # documentation. # +switcher_version = version +if ".dev" in version: + switcher_version = "dev/" +else: + # If we are not building dev version of the docs, we are building + # docs for the stable version + switcher_version = "" Review Comment: I think we will need to check for the numbered version of the docs here (13.0.0, 14.0.0, etc) and set the `switcher_version` to the number extracted from the version string (if not dev) so that once the docs get copied into the subdirectory will be correctly and equal to the version in the `versions.json`. Then all the docs versions (old and dev), except stable, should have the correct text in the version switcher button. For the stable version - should we open a PR upstream to change the default text? 😊 ########## docs/source/conf.py: ########## @@ -288,6 +288,14 @@ # documentation. # +switcher_version = version +if ".dev" in version: + switcher_version = "dev/" +else: + # If we are not building dev version of the docs, we are building + # docs for the stable version + switcher_version = "" Review Comment: I think we will need to check for the numbered version of the docs here (13.0.0, 14.0.0, etc) and set the `switcher_version` to the number extracted from the version string (if not dev) so that once the docs get copied into the subdirectory will be correctly and equal to the version in the `versions.json`. Then all the docs versions (old and dev), except stable, should have the correct text in the version switcher button. For the stable version - should we open a PR upstream to change the default text? 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
