AlenkaF commented on code in PR #38241: URL: https://github.com/apache/arrow/pull/38241#discussion_r1361629238
########## docs/source/conf.py: ########## @@ -288,6 +288,14 @@ # documentation. # +switcher_version = version +if ".dev" in version: + switcher_version = "dev/" +else: + # If we are not building dev version of the docs, we are building + # docs for the stable version + switcher_version = "" Review Comment: I am in favour of the second approach (patch the doc sources when moving) 👍 So this PR can be merged as is, the patch can be added as a follow up after the release, right? ########## docs/source/conf.py: ########## @@ -288,6 +288,14 @@ # documentation. # +switcher_version = version +if ".dev" in version: + switcher_version = "dev/" +else: + # If we are not building dev version of the docs, we are building + # docs for the stable version + switcher_version = "" Review Comment: I am in favour of the second approach (patch the doc sources when moving) 👍 So this PR can be merged as is, the patch can be added as a follow up after the release, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
