kevingurney commented on PR #38274: URL: https://github.com/apache/arrow/pull/38274#issuecomment-1764758190
@Divyansh200102 - thanks very much for the pull request! Just two small comments: 1. Could you please add a MATLAB test which verifies that passing in no arguments to the `arrow.recordBatch` function results in an empty `arrow.tabular.RecordBatch` being returned? You could add this to [`tRecordBatch.m`](https://github.com/apache/arrow/blob/main/matlab/test/arrow/tabular/tRecordBatch.m). 2. Although this is a small, one-line change - it isn't a documentation update. Therefore, I don't think this would normally be classified as a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#minor-fixes). Could you please update the title of this pull request to the following: **GH-38211: [MATLAB] Add support for creating an empty `arrow.tabular.RecordBatch` by calling `arrow.recordBatch` with no input arguments**? --- Please don't hesitate to let me know if you have any questions. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
