kevingurney commented on code in PR #38274:
URL: https://github.com/apache/arrow/pull/38274#discussion_r1360881520
##########
matlab/src/matlab/+arrow/recordBatch.m:
##########
@@ -16,7 +16,7 @@
% permissions and limitations under the License.
function rb = recordBatch(T)
arguments
- T table
+ T table= table.empty(0, 0)
Review Comment:
1. Could you add `{istable}` here?
Example:
https://github.com/apache/arrow/blob/cbf1bb50875cc9716fccbb55b3d4cf9e8a33e4cd/matlab/src/matlab/%2Barrow/table.m#L21
This will ensure an error is thrown if non-`table` inputs are provided to
the `arrow.recordBatch` function.
2. For clarity (and consistency with the `arrow.table` function), perhaps we
should rename `T` to `matlabTable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
