AlenkaF commented on code in PR #38241:
URL: https://github.com/apache/arrow/pull/38241#discussion_r1361684708
##########
docs/source/conf.py:
##########
@@ -312,8 +320,8 @@
],
"show_version_warning_banner": True,
"switcher": {
- "json_url": "/docs/_static/versions.json",
- "version_match": version,
+ "json_url": "https://arrow.apache.org/docs/_static/versions.json";,
Review Comment:
> I think the main benefit is that it doesn't tie us to the exact base url
(since it's always pointing relative to the root url), like if arrow.apache.org
would change to something else. Which is quite unlikely on the short term, and
even if it happens, it's also just a simple patch to the older doc built
sources to replace `DOCUMENTATION_OPTIONS.theme_switcher_json_url = "...";`
Yes, I agree. We synced the work so the change for "json_url" is not added,
but can be later if we see fit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
