wiedld commented on code in PR #7798:
URL: https://github.com/apache/arrow-datafusion/pull/7798#discussion_r1362670181
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -284,6 +333,34 @@ impl<T: FieldValues> Cursor for FieldCursor<T> {
self.offset += 1;
t
}
+
+ fn slice(&self, offset: usize, length: usize) -> Self {
Review Comment:
The RowCursor slicing does not slice the underlying rows, therefore it is
`self.offset + offset`.
Whereas the FieldCursor does slice the underlying data, and therefore the
offset is reset to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
