tustvold commented on code in PR #7798:
URL: https://github.com/apache/arrow-datafusion/pull/7798#discussion_r1362679917
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -284,6 +333,34 @@ impl<T: FieldValues> Cursor for FieldCursor<T> {
self.offset += 1;
t
}
+
+ fn slice(&self, offset: usize, length: usize) -> Self {
+ let FieldCursor {
+ values,
+ offset: _,
Review Comment:
I don't see an issue with slicing the underlying values, my observation is
that the following will behave differently between RowCursor and FieldCursor
```
cursor.advance();
cursor.slice(1, 2);
```
In the case of `RowCursor` it will produce a slice that is offset by 2 from
the start, whereas FieldCursor will produce one that is only offset by 1? I
think...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
