tustvold commented on code in PR #4944:
URL: https://github.com/apache/arrow-rs/pull/4944#discussion_r1363573612
##########
object_store/src/azure/mod.rs:
##########
@@ -170,11 +170,13 @@ impl std::fmt::Display for MicrosoftAzure {
#[async_trait]
impl ObjectStore for MicrosoftAzure {
- async fn put(&self, location: &Path, bytes: Bytes) -> Result<()> {
- self.client
+ async fn put(&self, location: &Path, bytes: Bytes) -> Result<PutResult> {
+ let response = self
+ .client
.put_request(location, Some(bytes), false, &())
.await?;
- Ok(())
+ let e_tag = Some(get_etag(response.headers()).context(MetadataSnafu)?);
Review Comment:
The actual object stores guarantee it is present, the same is technically
true of WebDav, but given HTTPStore gets used for more than that I opted to not
make it so strict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
