tustvold commented on code in PR #4944:
URL: https://github.com/apache/arrow-rs/pull/4944#discussion_r1363901689


##########
object_store/src/aws/mod.rs:
##########
@@ -365,10 +359,9 @@ struct S3MultiPartUpload {
 #[async_trait]
 impl PutPart for S3MultiPartUpload {
     async fn put_part(&self, buf: Vec<u8>, part_idx: usize) -> Result<PartId> {
-        use reqwest::header::ETAG;
         let part = (part_idx + 1).to_string();
 
-        let response = self
+        let content_id = self

Review Comment:
   It's because PartId is used across multiple stores, and for some of them 
this isn't an etag but a part number



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to