paleolimbot commented on code in PR #1206:
URL: https://github.com/apache/arrow-adbc/pull/1206#discussion_r1364034605
##########
r/adbcdrivermanager/src/error.cc:
##########
@@ -48,9 +48,28 @@ extern "C" SEXP RAdbcAllocateError(SEXP shelter_sexp) {
return error_xptr;
}
+static SEXP wrap_error_details(AdbcError* error) {
+ int n_details = AdbcErrorGetDetailCount(error);
+ SEXP result_names = PROTECT(Rf_allocVector(STRSXP, n_details));
+ SEXP result = PROTECT(Rf_allocVector(VECSXP, n_details));
+
+ for (int i = 0; i < n_details; i++) {
Review Comment:
I always wondered why I saw that in other code! I don't know if it's
official, but it looks like all `for()` loops in the arrow-adbc repo use `i++`
in for loops (so I will probably keep that as-is here for consistency).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
