paleolimbot commented on code in PR #1206:
URL: https://github.com/apache/arrow-adbc/pull/1206#discussion_r1364070466
##########
r/adbcdrivermanager/src/radbc.cc:
##########
@@ -319,8 +295,8 @@ extern "C" SEXP RAdbcConnectionGetTableSchema(SEXP
connection_xptr, SEXP catalog
SEXP db_schema_sexp, SEXP
table_name_sexp,
SEXP schema_xptr, SEXP
error_xptr) {
auto connection = adbc_from_xptr<AdbcConnection>(connection_xptr);
- const char* catalog = adbc_as_const_char(catalog_sexp);
- const char* db_schema = adbc_as_const_char(db_schema_sexp);
+ const char* catalog = adbc_as_const_char(catalog_sexp, true);
Review Comment:
Good call!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
