paleolimbot commented on code in PR #38236:
URL: https://github.com/apache/arrow/pull/38236#discussion_r1364107626
##########
r/configure.win:
##########
@@ -38,8 +38,7 @@ GCS_LIBS="-lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto
-lcrypt32 -lwldap32 \
function configure_release() {
VERSION=$(grep ^Version DESCRIPTION | sed s/Version:\ //)
# Try to find/download a C++ Arrow binary,
- # including possibly a local .zip file if RWINLIB_LOCAL is set
- "${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" "tools/winlibs.R" $VERSION
$RWINLIB_LOCAL
+ "${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" "tools/nixlibs.R" $VERSION
Review Comment:
Hmm...maybe `build-or-fetch-libarrow.R`? Or maybe just `build-libarrow.R` if
we don't want the fetch to be extra explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
