assignUser commented on code in PR #38236:
URL: https://github.com/apache/arrow/pull/38236#discussion_r1363102472
##########
r/tools/nixlibs.R:
##########
@@ -171,16 +162,16 @@ identify_binary <- function(lib =
Sys.getenv("LIBARROW_BINARY"), info = distro()
if (identical(lib, "false")) {
# Do not download a binary
- NULL
+ lib <- NULL
} else if (!identical(lib, "true")) {
# Env var provided an os-version to use, to override our logic.
# We don't validate that this exists. If it doesn't, the download will fail
# and the build will fall back to building from source
- lib
} else {
# See if we can find a suitable binary
- select_binary()
+ lib <- select_binary()
}
+ return(lib)
Review Comment:
Are there any functional benefits to not using explicit return? afaik it's
only a style thing right? Though tidyverse style is to use implicit return
unless early return so I will change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
