davidhcoe commented on code in PR #1183:
URL: https://github.com/apache/arrow-adbc/pull/1183#discussion_r1364342628
##########
csharp/src/Client/SchemaConverter.cs:
##########
@@ -58,15 +61,20 @@ public static DataTable ConvertArrowSchema(Schema schema,
AdbcStatement adbcStat
row[SchemaTableColumn.ColumnName] = f.Name;
row[SchemaTableColumn.ColumnOrdinal] = columnOrdinal;
row[SchemaTableColumn.AllowDBNull] = f.IsNullable;
- row[SchemaTableColumn.ProviderType] = f.DataType;
+ row[ArrowTypeName] = f.DataType;
Type t = ConvertArrowType(f);
row[SchemaTableColumn.DataType] = t;
+ if (f.HasMetadata && f.Metadata.ContainsKey("logicalType"))
Review Comment:
I would rather see the caller of the client specify what the value should be
(because the caller knows the driver it is working with) rather than try to
maintain that internal to the client library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
