zeroshade commented on code in PR #37599:
URL: https://github.com/apache/arrow/pull/37599#discussion_r1364421121
##########
go/parquet/file/column_writer_types.gen.go.tmpl:
##########
@@ -193,14 +193,23 @@ func (w *{{.Name}}ColumnChunkWriter)
WriteDictIndices(indices arrow.Array, defLe
valueOffset += info.numSpaced()
})
-
+
return
}
func (w *{{.Name}}ColumnChunkWriter) writeValues(values []{{.name}}, numNulls
int64) {
w.currentEncoder.(encoding.{{.Name}}Encoder).Put(values)
if w.pageStatistics != nil {
+{{- if ne .Name "FixedLenByteArray"}}
w.pageStatistics.(*metadata.{{.Name}}Statistics).Update(values, numNulls)
+{{- else}}
+ s, ok := w.pageStatistics.(*metadata.{{.Name}}Statistics)
+ if ok {
+ s.Update(values, numNulls)
+ } else {
+ w.pageStatistics.(*metadata.Float16Statistics).Update(values, numNulls)
+ }
+{{- end}}
Review Comment:
looks good! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
