zeroshade commented on code in PR #37599:
URL: https://github.com/apache/arrow/pull/37599#discussion_r1364433620
##########
go/parquet/schema/reflection_test.go:
##########
@@ -152,6 +152,7 @@ func ExampleNewSchemaFromStruct_logicaltypes() {
JSON string `parquet:"logical=json"`
BSON []byte `parquet:"logical=BSON"`
UUID [16]byte `parquet:"logical=uuid"`
+ Float16 [2]byte `parquet:"logical=float16"`
Review Comment:
the expected result for the `float16.Num` would be float16 column as per the
spec (fixed len binary + float16 logical type). It shouldn't need the
`parquet:"logical=float16"` if the type is `float16.Num`.
You may need to special case the code to check for the float16.Num type to
allow it through
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
