kou commented on PR #38116: URL: https://github.com/apache/arrow/pull/38116#issuecomment-1771945670
I suggest that reusing `FunctionRegistry` instead of introducing new `FunctionRegistrar` and `LLVMExternalBitcodeStore`. And `Projector::Make()`/`Filter::Make()` accepts `FunctionRegistry` (the default is `gandiva::default_function_registry()`) and passes it to `LLVMGenerator`. `LLVMGenerator`/`Engine` extracts needed information from their `FunctionRegistry`. (Sorry. I haven't tried implementing this API. So I may miss something.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
