alamb commented on code in PR #7885:
URL: https://github.com/apache/arrow-datafusion/pull/7885#discussion_r1367138171
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -235,18 +247,16 @@ impl Display for Interval {
impl Interval {
/// Creates a new interval object using the given bounds.
///
- /// # Boolean intervals need special handling
+ /// As explained in [`Interval]` boolean `Interval`s are special and this
Review Comment:
Given that there are only three valid boolean intervals, and
`Interval::new()` normalizes any provided into into one of those, it might make
sense to make the fields of `Interval` non `pub` so that it is not possible to
construct an invalid Interval
What do you think @metesynnada / @berkaysynnada / @ozankabak ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
