berkaysynnada commented on code in PR #7885:
URL: https://github.com/apache/arrow-datafusion/pull/7885#discussion_r1367732159
##########
datafusion/physical-expr/src/intervals/interval_aritmetic.rs:
##########
@@ -235,18 +247,16 @@ impl Display for Interval {
impl Interval {
/// Creates a new interval object using the given bounds.
///
- /// # Boolean intervals need special handling
+ /// As explained in [`Interval]` boolean `Interval`s are special and this
Review Comment:
In fact, that's exactly what I'm working on. I have planned to set the
fields to private and create intervals with only `try_new`. If an interval can
be created with the given parameters, it creates that interval. If the
parameters cannot construct a valid interval (like lower: `[true` - upper:
`false]` for a boolean interval), it returns an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
