CurtHagenlocher commented on code in PR #1207:
URL: https://github.com/apache/arrow-adbc/pull/1207#discussion_r1367479093
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -326,7 +326,7 @@ func (c *cnxn) getObjectsDbSchemas(ctx context.Context,
depth adbc.ObjectDepth,
IF (counter > 0) THEN
statement := statement || ' UNION ALL ';
END IF;
- statement := statement || ' SELECT
CATALOG_NAME, SCHEMA_NAME FROM ' || rec.database_name ||
'.INFORMATION_SCHEMA.SCHEMATA';
+ statement := statement || ' SELECT
CATALOG_NAME, SCHEMA_NAME FROM "' || rec.database_name ||
'".INFORMATION_SCHEMA.SCHEMATA';
Review Comment:
Sorry, I meant to say "double quote". That same link says "To use the double
quote character inside a quoted identifier, use two quotes" and as an example
it gives
create table "quote""andunquote"""
If a table name can contain a double quote then perhaps a database name can
also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
