zeroshade commented on code in PR #1207:
URL: https://github.com/apache/arrow-adbc/pull/1207#discussion_r1364048001
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -677,87 +674,88 @@ func (suite *SnowflakeTests) TestUseHighPrecision() {
suite.Equal(9876543210.99, rec.Column(1).(*array.Float64).Value(1))
}
-func TestUnencryptedJwtAuthenticationUsingString(t *testing.T) {
- drv := gosnowflake.SnowflakeDriver{}
-
+func TestJwtAuthenticationUnencryptedValue(t *testing.T) {
+ // test doesn't participate in SnowflakeTests because of the
+ // JWT auth has a different behavior
uri, ok := os.LookupEnv("SNOWFLAKE_URI")
-
if !ok {
- panic("Cannot find the `SNOWFLAKE_URI` value")
+ t.Skip("Cannot find the `SNOWFLAKE_URI` value")
}
- cfg, _ := gosnowflake.ParseDSN(uri)
- cfg.Authenticator = gosnowflake.AuthTypeJwt
-
keyValue, ok := os.LookupEnv("SNOWFLAKE_TEST_PKCS8_VALUE")
Review Comment:
does this need to get added as a secret on the repo? or do we have a
hardcoded test value to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
