mapleFU commented on code in PR #38413:
URL: https://github.com/apache/arrow/pull/38413#discussion_r1368995387
##########
go/parquet/internal/encoding/delta_bit_packing.go:
##########
@@ -172,6 +174,10 @@ func (d *DeltaBitPackInt32Decoder) Decode(out []int32)
(int, error) {
for len(out) > 0 { // unpack mini blocks until we get all the values we
need
if d.currentBlockVals == 0 {
err = d.initBlock()
+ if err != nil {
+ return 0, err
+ }
+ d.currentMiniBlockVals = 0
Review Comment:
Yeah. Previously I though it might raise from data on last block(
already-read + d.currentBlockVals would greater than max). However finally I
found that here it will limit by `out` and `max`. So this line can be moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
