mapleFU commented on code in PR #38413:
URL: https://github.com/apache/arrow/pull/38413#discussion_r1368996270
##########
go/parquet/internal/encoding/delta_bit_packing.go:
##########
@@ -82,9 +82,12 @@ func (d *deltaBitPackDecoder) SetData(nvalues int, data
[]byte) error {
return xerrors.New("parquet: eof exception")
}
- if d.miniBlocks, ok = d.bitdecoder.GetVlqInt(); !ok {
+ if d.miniBlocksPerBlock, ok = d.bitdecoder.GetVlqInt(); !ok {
return xerrors.New("parquet: eof exception")
}
+ if d.miniBlocksPerBlock == 0 {
+ return xerrors.New("parquet: cannot have zero miniblock per
block")
Review Comment:
Should I replace the `xerrors` in this file? Since mixing `xerror` and
standard lib is so weird :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
