jayzhan211 commented on code in PR #7242:
URL: https://github.com/apache/arrow-datafusion/pull/7242#discussion_r1369431592
##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -167,7 +172,7 @@ impl PartialEq<dyn Any> for Sum {
/// This accumulator computes SUM incrementally
Review Comment:
I'm thinking about introducing `AggregateFunction::ArraySum` for
array_aggreate('sum') and creating an accumulator `SumAccumulator` that is
specialized for array cases, instead of introducing `ArraySumAccumulator` under
the existing `AggregateFunction::Sum`.
We also need to do the same to other functions, e.g. `avg`, `min`, `max`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
