jayzhan211 commented on code in PR #7242:
URL: https://github.com/apache/arrow-datafusion/pull/7242#discussion_r1372471567


##########
datafusion/sql/src/expr/function.rs:
##########
@@ -59,6 +60,26 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         if let Ok(fun) = BuiltinScalarFunction::from_str(&name) {
             let args =
                 self.function_args_to_expr(function.args, schema, 
planner_context)?;
+
+            // Translate array_aggregate to aggregate function with array 
argument.
+            if fun == BuiltinScalarFunction::ArrayAggregate {

Review Comment:
   Let's raise another PR to have a common rewriting rule for SQL, Dataframe, 
and Expr. I would need more time to deep dive into them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to