niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1369910894
##########
cpp/src/gandiva/tests/filter_test.cc:
##########
@@ -42,8 +42,8 @@ class TestFilter : public ::testing::Test {
TEST_F(TestFilter, TestFilterCache) {
// schema for input fields
- auto field0 = field("f0", int32());
- auto field1 = field("f1", int32());
+ auto field0 = field("f0_filter_cache", int32());
+ auto field1 = field("f1_filter_cache", int32());
auto schema = arrow::schema({field0, field1});
// Build condition f0 + f1 < 10
Review Comment:
This test case was a flaky test previously, and its success depends on its
order to be executed within the test suite. There is another test case
`TestNullValidity.TestFunc` which build the same schema (`f0/f1`) and the same
expression (`f0 + f1 < 10`) and may populate the code cache accidentally, which
will make the assertion `EXPECT_FALSE(filter->GetBuiltFromCache());` in this
test case to fail if `TestNullValidity.TestFunc` test is run before this test
case (see the CI job failure here,
https://github.com/apache/arrow/actions/runs/6614817906/job/17965596013?pr=38116#step:7:3945).
Now I change the field name to unusual field names, which makes it unlikely
to be conflict with other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
