niyue commented on code in PR #38116:
URL: https://github.com/apache/arrow/pull/38116#discussion_r1368821889
##########
cpp/src/gandiva/expression_registry.h:
##########
@@ -62,7 +64,7 @@ class GANDIVA_EXPORT ExpressionRegistry {
private:
static DataTypeVector supported_types_;
- std::unique_ptr<FunctionRegistry> function_registry_;
Review Comment:
> If default_function_registry is already a public API
No, it is not a public API yet (it is introduced in this PR), so I think we
still have the chance to change its signature if needed. Currently, this
`gandiva::default_function_registry()` function's signature and usage mimics
`arrow::default_memory_pool()` which returns a `MemoryPool *` raw pointer. Do
you mean we should change this API to return a
`std::shared_ptr<FunctionRegistry>` like this:
```C++
namespace gandiva {
std::shared_ptr<FunctionRegistry> default_function_registry();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
