tustvold commented on code in PR #4984:
URL: https://github.com/apache/arrow-rs/pull/4984#discussion_r1372380286


##########
object_store/src/gcp/client.rs:
##########
@@ -375,13 +440,18 @@ impl GetClient for GoogleCloudStorageClient {
             false => Method::GET,
         };
 
-        let mut request = self.client.request(method, 
url).with_get_options(options);
+        let mut request = self.client.request(method, url);
+
+        if let Some(version) = &options.version {
+            request = request.query(&[("generation", version)]);
+        }

Review Comment:
   This was a merge conflict from #4935 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to