tustvold commented on code in PR #4984:
URL: https://github.com/apache/arrow-rs/pull/4984#discussion_r1372382280
##########
object_store/src/http/mod.rs:
##########
@@ -96,14 +96,23 @@ impl std::fmt::Display for HttpStore {
#[async_trait]
impl ObjectStore for HttpStore {
- async fn put(&self, location: &Path, bytes: Bytes) -> Result<PutResult> {
+ async fn put_opts(&self, location: &Path, bytes: Bytes, opts: PutOptions)
-> Result<PutResult> {
+ if opts.mode != PutMode::Overwrite {
+ // TODO: Add support for If header -
https://datatracker.ietf.org/doc/html/rfc2518#section-9.4
Review Comment:
I couldn't actually find an easy to run WebDav implementation that respected
this header, I don't have a use-case for this currently so punted on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
