junjunjd commented on PR #7901: URL: https://github.com/apache/arrow-datafusion/pull/7901#issuecomment-1780426607
> Epic work @junjunjd thanks I'm thinking if we can get rid of `.expect` ? Or at least provide more details in expect message? I removed the `.expect` in [`get_min_max_values`](https://github.com/apache/arrow-datafusion/blob/4b6180768f6ce38ab95ba1ddcc817f5bcfbd1ed7/datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs#L204) and [`get_null_count_values`](https://github.com/apache/arrow-datafusion/blob/4b6180768f6ce38ab95ba1ddcc817f5bcfbd1ed7/datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs#L224) macros. The rest of the `.expect` calls exist in tests or examples. It makes sense to use `.expect` and panic there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
