Weijun-H commented on code in PR #7901:
URL: https://github.com/apache/arrow-datafusion/pull/7901#discussion_r1372788072
##########
datafusion/common/src/scalar.rs:
##########
@@ -3468,22 +3541,30 @@ mod tests {
}
// decimal scalar to array
- let array = decimal_value.to_array();
+ let array = decimal_value
+ .to_array()
+ .expect("Failed to convert to array");
Review Comment:
```suggestion
let array = decimal_value
.to_array()?;
```
##########
datafusion/common/src/scalar.rs:
##########
@@ -3419,8 +3492,8 @@ mod tests {
{
let scalar_result = left.add_checked(&right);
- let left_array = left.to_array();
- let right_array = right.to_array();
+ let left_array = left.to_array().expect("Failed to convert to array");
+ let right_array = right.to_array().expect("Failed to convert to
array");
Review Comment:
```suggestion
let right_array = right.to_array().expect("Failed to convert to
array in add overflow check");
```
##########
datafusion/common/src/scalar.rs:
##########
@@ -3468,22 +3541,30 @@ mod tests {
}
// decimal scalar to array
- let array = decimal_value.to_array();
+ let array = decimal_value
+ .to_array()
+ .expect("Failed to convert to array");
let array = as_decimal128_array(&array)?;
assert_eq!(1, array.len());
assert_eq!(DataType::Decimal128(10, 1), array.data_type().clone());
assert_eq!(123i128, array.value(0));
// decimal scalar to array with size
- let array = decimal_value.to_array_of_size(10);
+ let array = decimal_value
+ .to_array_of_size(10)
+ .expect("Failed to convert to array of size");
let array_decimal = as_decimal128_array(&array)?;
assert_eq!(10, array.len());
assert_eq!(DataType::Decimal128(10, 1), array.data_type().clone());
assert_eq!(123i128, array_decimal.value(0));
assert_eq!(123i128, array_decimal.value(9));
// test eq array
- assert!(decimal_value.eq_array(&array, 1));
- assert!(decimal_value.eq_array(&array, 5));
+ assert!(decimal_value
+ .eq_array(&array, 1)
+ .expect("Failed to compare arrays"));
+ assert!(decimal_value
+ .eq_array(&array, 5)
+ .expect("Failed to compare arrays"));
Review Comment:
```suggestion
assert!(decimal_value
.eq_array(&array, 1)?);
assert!(decimal_value
.eq_array(&array, 5)?);
```
##########
datafusion/common/src/scalar.rs:
##########
@@ -3419,8 +3492,8 @@ mod tests {
{
let scalar_result = left.add_checked(&right);
- let left_array = left.to_array();
- let right_array = right.to_array();
+ let left_array = left.to_array().expect("Failed to convert to array");
Review Comment:
```suggestion
let left_array = left.to_array().expect("Failed to convert to array
in add overflow check");
```
##########
datafusion/common/src/scalar.rs:
##########
@@ -3468,22 +3541,30 @@ mod tests {
}
// decimal scalar to array
- let array = decimal_value.to_array();
+ let array = decimal_value
+ .to_array()
+ .expect("Failed to convert to array");
let array = as_decimal128_array(&array)?;
assert_eq!(1, array.len());
assert_eq!(DataType::Decimal128(10, 1), array.data_type().clone());
assert_eq!(123i128, array.value(0));
// decimal scalar to array with size
- let array = decimal_value.to_array_of_size(10);
+ let array = decimal_value
+ .to_array_of_size(10)
+ .expect("Failed to convert to array of size");
Review Comment:
```suggestion
let array = decimal_value
.to_array_of_size(10)?;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
