jduo commented on code in PR #38461:
URL: https://github.com/apache/arrow/pull/38461#discussion_r1373920916


##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightServer.java:
##########
@@ -317,6 +340,15 @@ public Builder useTls(final File certChain, final File 
key) throws IOException {
       return this;
     }
 
+    /**
+     * Enable Client Verification via mTLS on the server.
+     * @param mTlsCACert The CA certificate to use for verifying clients.
+     */
+    public Builder useMTlsClientVerification(final File mTlsCACert) throws 
IOException {
+      this.mTlsCACert = new FileInputStream(mTlsCACert);

Review Comment:
   If the user calls this method repeatedly we will leak File handles. Need to 
close the current one if it exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to