prmoore77 commented on PR #38461: URL: https://github.com/apache/arrow/pull/38461#issuecomment-1783941268
Hello – it could be added, but the Java Flight client doesn’t yet support that to my knowledge – so I just wanted to catch up to that for now. We can add it in a later PR, unless you feel strongly that it should be included here. From: david dali susanibar arce ***@***.***> Date: Saturday, October 28, 2023 at 7:20 PM To: apache/arrow ***@***.***> Cc: prmoore77 ***@***.***>, Mention ***@***.***> Subject: Re: [apache/arrow] GH-38460: [Java][FlightRPC] Add mTLS support for Flight SQL JDBC driver (PR #38461) @davisusanibar commented on this pull request. Thank you for the PR. I am adding a few minor questions. ________________________________ In docs/source/java/flight_sql_jdbc_driver.rst<https://github.com/apache/arrow/pull/38461#discussion_r1375164054>: > @@ -114,6 +114,21 @@ parameters are: - null - When TLS is enabled, the password for the certificate store + * - tlsRootCerts + - null + - Path to PEM-encoded root certificates for TLS - use this as + an alternative to ``trustStore`` + + * - clientCertificate + - null + - Path to PEM-encoded client mTLS certificate when the Flight + SQL server requires client verification. + + * - clientKey Will it be necessary to provide an optional client key password argument if this client private key is password-protected? — Reply to this email directly, view it on GitHub<https://github.com/apache/arrow/pull/38461#pullrequestreview-1702696629>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE6YADM4XNIWREIU7OLCZNDYBWHK7AVCNFSM6AAAAAA6PORM76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBSGY4TMNRSHE>. You are receiving this because you were mentioned.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
