comphead commented on code in PR #7963:
URL: https://github.com/apache/arrow-datafusion/pull/7963#discussion_r1375309495
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1946,6 +1950,47 @@ mod tests {
};
use datafusion_common::scalar::ScalarValue;
+ #[test]
+ fn test_align_array_dimensions() {
+ let array1d_1 =
+ Arc::new(ListArray::from_iter_primitive::<Int64Type, _, _>(vec![
+ Some(vec![Some(1), Some(2), Some(3)]),
+ Some(vec![Some(4), Some(5)]),
+ ]));
+ let array1d_2 =
+ Arc::new(ListArray::from_iter_primitive::<Int64Type, _, _>(vec![
+ Some(vec![Some(6), Some(7), Some(8)]),
+ ]));
+
+ let array2d_1 = Arc::new(wrap_into_list_array(array1d_1.clone())) as
ArrayRef;
+ let array2d_2 = Arc::new(wrap_into_list_array(array1d_2.clone())) as
ArrayRef;
+
+ let res =
+ align_array_dimensions(vec![array1d_1.to_owned(),
array2d_2.to_owned()])
+ .expect("should not error");
Review Comment:
Please add more descriptive text in `expect`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]