comphead commented on PR #7963: URL: https://github.com/apache/arrow-datafusion/pull/7963#issuecomment-1789886375
> > Thanks @jayzhan211 I'll check this later today, please add the github issue what this ticket is supposed to close. Personally for me, I'm not really sure what exactly we improving or fixing, is it some issue requiring this fix? Please create a github issue with details and connect it to this PR > > This is just a minor improvement that removes the duplicated `compute_ndim_arrays`, I don't think we really need to create every issue for such a minor improvement. That is true, for minors sometimes people avoid the originating github issue, which basically a little bit breaks the issue tracking. For the implementation, the its a nice idea to create a collection ndims along with separate max value and then zip the collection. However the complexity of method explodes with conditional statememts, I strongly believe it can be improved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
