andygrove commented on code in PR #7956: URL: https://github.com/apache/arrow-datafusion/pull/7956#discussion_r1376226013
########## docs/README.md: ########## @@ -53,6 +60,25 @@ To make changes to the docs, simply make a Pull Request with your proposed changes as normal. When the PR is merged the docs will be automatically updated. +## Including Source Code + +We want to make sure that all source code in the documentation is tested as part of the build and release process. We Review Comment: This approach is more challenging because sometimes we are copying a whole function, and sometimes just a few lines of code, and some snippets depend on other snippets. It is also hard to write and test code with this approach because there is no IDE support. ########## docs/build.sh: ########## @@ -21,8 +21,14 @@ set -e rm -rf build 2> /dev/null rm -rf temp 2> /dev/null + +# copy source to temp dir Review Comment: Thanks, I had missed that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
