alamb commented on PR #7956:
URL:
https://github.com/apache/arrow-datafusion/pull/7956#issuecomment-1800276891
I took the liberty of merging this branch to main.
While I was testing it it turns out there are a bunch of clippy errors in
the library code now such as
```
error: unused imports: `SessionContext`, `create_udf`
--> docs/src/library_udfs.rs:24:27
|
24 | use datafusion::prelude::{create_udf, SessionContext};
| ^^^^^^^^^^ ^^^^^^^^^^^^^^
error: this import is redundant
--> docs/src/library_udfs.rs:26:1
|
26 | use tokio;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `-D clippy::single-component-path-imports` implied by `-D
warnings`
error: function `add_one` is never used
--> docs/src/library_udfs.rs:29:4
|
29 | fn add_one(args: &[ArrayRef]) -> Result<ArrayRef> {
| ^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
```
However, this PR seems not to trigger the full CI checks (probably because
it only runs the docs workflow):
https://github.com/apache/arrow-datafusion/blob/main/.github/workflows/docs_pr.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
