tustvold commented on code in PR #8007:
URL: https://github.com/apache/arrow-datafusion/pull/8007#discussion_r1377617860
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -855,14 +855,17 @@ impl TableProvider for ListingTable {
let input_partitions = input.output_partitioning().partition_count();
let writer_mode = match self.options.insert_mode {
ListingTableInsertMode::AppendToFile => {
- if input_partitions > file_groups.len() {
+ if file_groups.is_empty() && self.options.single_file {
+ // This is a hack, longer term append should be split out
(#7994)
Review Comment:
Without this we get an error if this is the first write as there are no
file_groups. Longer-term we shouldn't be conflating ListingTable IO and that of
streaming use-cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
