tustvold commented on code in PR #8007:
URL: https://github.com/apache/arrow-datafusion/pull/8007#discussion_r1377686735
##########
datafusion/core/src/datasource/listing/url.rs:
##########
@@ -46,37 +46,49 @@ pub struct ListingTableUrl {
impl ListingTableUrl {
/// Parse a provided string as a `ListingTableUrl`
///
+ /// A URL can either refer to a single object, or a collection of objects
with a
+ /// common prefix, with the presence of a trailing `/` indicating a
collection.
+ ///
+ /// For example, `file:///foo.txt` refers to the file at `/foo.txt`,
whereas
+ /// `file:///foo/` refers to all the files under the directory `/foo` and
its
+ /// subdirectories.
+ ///
+ /// Similarly `s3://BUCKET/blob.csv` refers to `blob.csv` in the S3 bucket
`BUCKET`,
+ /// wherease `s3://BUCKET/foo/` refers to all objects with the prefix
`foo/` in the
+ /// S3 bucket `BUCKET`
+ ///
/// # Paths without a Scheme
///
/// If no scheme is provided, or the string is an absolute filesystem path
- /// as determined [`std::path::Path::is_absolute`], the string will be
+ /// as determined by [`std::path::Path::is_absolute`], the string will be
/// interpreted as a path on the local filesystem using the operating
/// system's standard path delimiter, i.e. `\` on Windows, `/` on Unix.
///
/// If the path contains any of `'?', '*', '['`, it will be considered
/// a glob expression and resolved as described in the section below.
///
- /// Otherwise, the path will be resolved to an absolute path, returning
- /// an error if it does not exist, and converted to a [file URI]
+ /// Otherwise, the path will be resolved to an absolute path based on the
current
+ /// working directory, and converted to a [file URI].
///
- /// If you wish to specify a path that does not exist on the local
- /// machine you must provide it as a fully-qualified [file URI]
- /// e.g. `file:///myfile.txt`
+ /// If the path already exists in the local filesystem this will be used
to determine if this
Review Comment:
This is necessary to preserve the pre-existing behaviour where it would use
the filesystem to determine if the path refers to a directory or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
